refs #4286 -- allow setting submodule on declarative pymodules #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
pymodule-submodule
branch
2 times, most recently
from
f4c04ca to
6fdcf0e
Compare
|
This makes a lot of sense, thanks. I wonder, should we go further and make it so that That way, explicitly marking Maybe that makes the rules too magical and complex 🤔. I think it's hopefully quite intuitive though? |
|
I would like to auto-set submodule, but figured I would do this in two
parts.
…On Mon, Jul 1, 2024, 9:20 AM David Hewitt ***@***.***> wrote:
This makes a lot of sense, thanks. I wonder, should we go further and make
it so that submodule is set by default when nested, similar to what we
already do with module setting?
That way, explicitly marking submodule is only necessary if the module is
"top-level" as far as Rust source structure goes.
Maybe that makes the rules too magical and complex 🤔. I think it's
hopefully quite intuitive though?
—
Reply to this email directly, view it on GitHub
<#4301 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBE4XDWCAM3K27HSUKLZKFJSBAVCNFSM6AAAAABKDOUMZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGEZDINJUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
davidhewitt
reviewed
Jul 1, 2024
| pymodule_module_impl(module, is_submodule) | ||
| } | ||
| Item::Fn(function) => { | ||
| parse_macro_input!(args as Nothing); |
There was a problem hiding this comment.
I think it seems reasonable to me for function modules to also support submodule?
There was a problem hiding this comment.
I'm not sure it's relevant for function modules -- there's never been a need to use #[pymodule] for submodules with functions.
alex
force-pushed
the
pymodule-submodule
branch
2 times, most recently
from
1e6dd87 to
9c154b5
Compare
davidhewitt
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.