Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl partialeq for pylong #4317
Impl partialeq for pylong #4317
Changes from all commits
6b6825b
652c196
9c7f261
af11d4c
f35cac3
ab549ee
b50df15
0b2954b
cc27a4f
ab2ac7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just completing my read of the full diff, this is interesting.
What I see here is that the introduction of these implementations has changed type inference here. It's a potentially breaking change.
Is it a problem? I don't think so; user code could already define other types implementing
FromPyObject
andPartialEq<u8>
and thus have the same inference failure.And I believe that this new
PartialEq
implementation here still holds potential convenience and usability improvements.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how this can be a breaking change. However, I don't think it's a major issue.
Ultimately, I'll leave the final decision to the maintainers haha 😃 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I think we move ahead with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider inference failures like this as breaking changes, so I'm also fine with this.