Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename PyLong to PyInt #4347

Merged
merged 3 commits into from
Jul 14, 2024
Merged

rename PyLong to PyInt #4347

merged 3 commits into from
Jul 14, 2024

Conversation

MatthijsKok
Copy link
Contributor

@MatthijsKok MatthijsKok commented Jul 13, 2024 •
edited
Loading

Implements #4260

@MatthijsKok MatthijsKok marked this pull request as ready for review July 13, 2024 22:45
Icxolu
Icxolu reviewed Jul 14, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have one small suggestion to make the #[deprecated] actually emit warnings, otherwise this looks good to me.

src/types/mod.rs Outdated Show resolved Hide resolved
@Icxolu Icxolu enabled auto-merge July 14, 2024 14:47
@Icxolu Icxolu added this pull request to the merge queue Jul 14, 2024
Merged via the queue into PyO3:main with commit 17f40ca Jul 14, 2024
42 checks passed
@MatthijsKok MatthijsKok deleted the rename-pylong-to-pyint branch July 14, 2024 15:41
@MatthijsKok MatthijsKok mentioned this pull request Jul 15, 2024
Closed
@davidhewitt davidhewitt mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsKok @Icxolu