Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PartialEq for PyFloat with f64 and f32 #4348

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Implement PartialEq for PyFloat with f64 and f32 #4348

merged 4 commits into from
Jul 16, 2024

Conversation

Owen-CH-Leung
Copy link
Contributor

This PR implements PartialEq for PyFloat with f64 and f32. See #4250

@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review July 14, 2024 04:02
LilyFoote
LilyFoote approved these changes Jul 14, 2024
View reviewed changes
src/types/float.rs Outdated Show resolved Hide resolved
@LilyFoote LilyFoote added this pull request to the merge queue Jul 16, 2024
Merged via the queue into PyO3:main with commit f635afc Jul 16, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu left review comments

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Owen-CH-Leung @LilyFoote @Icxolu