Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only emit c-string literals on Rust 1.79 and later (#4352) #4353

Merged
merged 2 commits into from
Jul 15, 2024
Merged

only emit c-string literals on Rust 1.79 and later (#4352) #4353

merged 2 commits into from
Jul 15, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Jul 15, 2024

See #4352 (comment)

Closes #4352

@Icxolu Icxolu mentioned this pull request Jul 15, 2024
Merged
davidhewitt
davidhewitt approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for fixing this, will include it in the release 👍

@davidhewitt davidhewitt added this pull request to the merge queue Jul 15, 2024
Merged via the queue into PyO3:main with commit e353166 Jul 15, 2024
42 checks passed
@Icxolu Icxolu deleted the fix/4352 branch July 15, 2024 19:49
davidhewitt pushed a commit that referenced this pull request Jul 16, 2024
@Icxolu @davidhewitt
only emit c-string literals on Rust 1.79 and later (#4352) (#4353)
909ab62 
* only emit c-string literals on Rust 1.79 and later (#4352)

* add newsfragment
davidhewitt pushed a commit that referenced this pull request Jul 16, 2024
@Icxolu @davidhewitt
only emit c-string literals on Rust 1.79 and later (#4352) (#4353)
2baac93 
* only emit c-string literals on Rust 1.79 and later (#4352)

* add newsfragment
davidhewitt pushed a commit that referenced this pull request Jul 17, 2024
@Icxolu @davidhewitt
only emit c-string literals on Rust 1.79 and later (#4352) (#4353)
da9f52e 
* only emit c-string literals on Rust 1.79 and later (#4352)

* add newsfragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LexError when upgrading from 0.21 to 0.22
2 participants
@Icxolu @davidhewitt