make abi3 feature apply to config imported from PYO3_BUILD_CONFIG
#4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given this unblocks #4451, I will fix the lint failures and merge this. |
davidhewitt
force-pushed
the
abi-feature-vs-config
branch
from
9bce9c4 to
9d1a057
Compare
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
PYO3_CONFIG_FILEsystem so that if theabi3feature is set but the config file didn't set it, theabi3feature wins.While a breaking change, people using
PYO3_CONFIG_FILEdirectly are relatively rare. I also think that it's better for theabi3feature to apply consistently rather than silently ignoring it.There's a case to be made that the
InterpreterConfigdoesn't need to have theabi3field as that's a property of the binding mode and not the interpreter, but that's a possible refactor for another time.