Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate PySet to IntoPyObject #4536

Merged
merged 2 commits into from
Sep 30, 2024
Merged

migrate PySet to IntoPyObject #4536

merged 2 commits into from
Sep 30, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Sep 6, 2024

  • adds BoundObject::as_ptr as a convenience function for a borrowed reference pointer
  • removed the "inner" function from try_new_from_iter, this is more codegen, but allows us to otherwise needed reference bumps

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Sep 6, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4536 will not alter performance

Comparing Icxolu:migrate-pyset (6e278c5) with main (bf16238)

Summary

✅ 81 untouched benchmarks

@Icxolu Icxolu mentioned this pull request Sep 13, 2024
Closed
3 tasks
davidhewitt
davidhewitt approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step closer! Thanks 👍

@davidhewitt davidhewitt added this pull request to the merge queue Sep 30, 2024
Merged via the queue into PyO3:main with commit 116170a Sep 30, 2024
42 of 44 checks passed
@Icxolu Icxolu deleted the migrate-pyset branch September 30, 2024 21:37
@Icxolu Icxolu mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icxolu @LilyFoote @davidhewitt