Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate PySequenceMethods trait bounds #4559

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Sep 16, 2024

This migrates the trait bounds of PySequenceMethods, PyListMethods and PyTupleMethods to IntoPyObject. Constructor migration for PyList and PyTuple will be in a followup to keep the diff a bit smaller.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Sep 16, 2024
@Icxolu Icxolu force-pushed the migrate-sequence-traits branch from 9e1b75f to 53d701c Compare September 16, 2024 17:11
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

@davidhewitt davidhewitt added this pull request to the merge queue Sep 26, 2024
Merged via the queue into PyO3:main with commit cb96613 Sep 26, 2024
43 checks passed
@Icxolu Icxolu deleted the migrate-sequence-traits branch September 26, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants