Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare free-threaded support for PyModule #4588

Merged
merged 41 commits into from
Nov 5, 2024
Merged

Declare free-threaded support for PyModule #4588

merged 41 commits into from
Nov 5, 2024

Conversation

ngoldbaum
Copy link
Contributor

@ngoldbaum ngoldbaum commented Oct 1, 2024 •
edited
Loading

Adds a supports_free_threaded argument to the pymodule macro and a supports_free_threaded method to PyModule.

Updates the tests and examples to mark that they support free-threading.

Removes UNSAFE_PYO3_BUILD_FREE_THREADED=1 from the build config.

@ngoldbaum
Copy link
Contributor Author

Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the python tests are fixed in the free-threaded build.

@ngoldbaum ngoldbaum mentioned this pull request Oct 21, 2024
Merged
@ngoldbaum
Copy link
Contributor Author

Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the python tests are fixed in the free-threaded build.

This is done now and I think all the tests are passing so I'm going to move this out of draft phase and update the PR description.

@ngoldbaum ngoldbaum marked this pull request as ready for review October 21, 2024 23:31
@ngoldbaum ngoldbaum changed the title WIP: declare free-threaded support in pymodule macro Declare free-threaded support for PyModule Oct 21, 2024
@ngoldbaum
Copy link
Contributor Author

This probably needs some discussion in the new guide section on free-threading support.

@ngoldbaum ngoldbaum mentioned this pull request Oct 21, 2024
Closed
ngoldbaum
ngoldbaum commented Oct 22, 2024
View reviewed changes
pyo3-ffi/build.rs Outdated Show resolved Hide resolved
@ngoldbaum ngoldbaum mentioned this pull request Oct 23, 2024
Merged
@ngoldbaum
Copy link
Contributor Author

woohoo! looks like tests are passing except for the codecov issue affecting all PRs right now.

@ngoldbaum ngoldbaum force-pushed the module-support branch 2 times, most recently from 599a58e to 8f86b9e Compare October 23, 2024 21:57
ngoldbaum
ngoldbaum commented Oct 23, 2024
View reviewed changes
src/macros.rs Outdated Show resolved Hide resolved
src/types/module.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, broadly looks great to me, a bunch of various thoughts :)

examples/decorator/src/lib.rs Outdated Show resolved Hide resolved
examples/sequential/src/module.rs Outdated Show resolved Hide resolved
examples/string-sum/src/lib.rs Outdated Show resolved Hide resolved
pyo3-ffi/build.rs Outdated Show resolved Hide resolved
pyo3-ffi/src/moduleobject.rs Outdated Show resolved Hide resolved
pyo3-ffi/src/moduleobject.rs Show resolved Hide resolved
guide/src/free-threading.md Outdated Show resolved Hide resolved
src/types/module.rs Outdated Show resolved Hide resolved
tests/ui/invalid_pymodule_args.stderr Outdated Show resolved Hide resolved
@davidhewitt davidhewitt mentioned this pull request Oct 25, 2024
Merged
5 tasks
@davidhewitt davidhewitt mentioned this pull request Oct 25, 2024
Open
@ngoldbaum ngoldbaum mentioned this pull request Oct 28, 2024
Merged
@ngoldbaum
Copy link
Contributor Author

ngoldbaum commented Oct 31, 2024 •
edited
Loading

It occurred to me while working on something else that this PR should remove the UNSAFE_PYO3_BUILD_FREE_THREADED uses in the CI scripts a well.

EDIT: done

davidhewitt
davidhewitt reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is looking pretty much there. Just some final tidy ups...

pyo3-ffi/examples/string-sum/src/lib.rs Show resolved Hide resolved
pyo3-macros-backend/src/module.rs Outdated Show resolved Hide resolved
pyo3-macros-backend/src/module.rs Outdated Show resolved Hide resolved
pytests/tests/test_free_threaded.py Outdated Show resolved Hide resolved
src/types/module.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, this looks ready to ship! Thanks very much for all the work here and on the rest of the freethreading PRs 🚀

@davidhewitt davidhewitt added this pull request to the merge queue Nov 5, 2024
Merged via the queue into PyO3:main with commit 76f4503 Nov 5, 2024
44 checks passed
@Aequitosh Aequitosh mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejrs mejrs mejrs left review comments

@henryiii henryiii henryiii left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngoldbaum @davidhewitt @henryiii @mejrs