Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leak references for safety in PyWeakRefMethods::upgrade_borrowed #4590

Merged
merged 2 commits into from
Oct 4, 2024
Merged

leak references for safety in PyWeakRefMethods::upgrade_borrowed #4590

merged 2 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Add PyWeakref_GetRef and use it in weakref wrappers. (PyO3#4528) 

    * add FFI bindings and a compat definition for PyWeakref_GetRef

* implement get_object method of weakref wrappers using PyWeakref_GetRef

* add changelog

* rename _ref argument to reference

* mark PyWeakref_GetObject as deprecated

* mark test as using deprecated API item

* update docs to reference PyWeakref_GetRef semantics

* remove weakref methods that return borrowed references

* fix lints about unused imports
    @ngoldbaum @davidhewitt
    ngoldbaum authored and davidhewitt committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    675e505 View commit details
    Browse the repository at this point in the history

  2. update test assertions to expect leaked objects

    @davidhewitt
    davidhewitt committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f31271f View commit details
    Browse the repository at this point in the history