add more IntoPyObject impls
#4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
force-pushed
the
intopyobject-impls
branch
from
995bf79 to
3fba5b5
Compare
Icxolu
force-pushed
the
intopyobject-impls
branch
from
3fba5b5 to
e01f764
Compare
davidhewitt
approved these changes
Oct 4, 2024
| @@ -64,6 +64,17 @@ impl<'py> IntoPyObject<'py> for &OsStr { | |||
| } | |||
| } | |||
|
|
|||
| impl<'py> IntoPyObject<'py> for &&OsStr { | |||
There was a problem hiding this comment.
All of these && implementations are interesting. I think if we were starting again we wouldn't offer them, but due to the existing ToPyObject implementations they already exist. I wonder if some time in the future we should remove these (presumably would be a micro-optimization to avoid the pointer-to-slice), but doesn't seem worth doing with all the other churn in 0.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working through the deprecation of
ToPyObjectI noticed a few missingIntoPyObjectimpls.