Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous associated item error #4725

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fix ambiguous associated item error #4725

merged 2 commits into from
Nov 23, 2024
+42 −6

Conversation

LilyFoote
Copy link
Contributor

Fixes #4723.

@LilyFoote LilyFoote added bugfix rust Pull requests that update Rust code labels Nov 21, 2024
@LilyFoote LilyFoote self-assigned this Nov 21, 2024
alex
alex approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible

Icxolu
Icxolu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So many edge cases to look out for 😅

pyo3-macros-backend/src/pyclass.rs Outdated Show resolved Hide resolved
@LilyFoote LilyFoote force-pushed the fix-ambiguous-associated-item-error branch 2 times, most recently from a858c2e to d7d5b54 Compare November 22, 2024 08:01
@davidhewitt davidhewitt mentioned this pull request Nov 22, 2024
Draft
@LilyFoote
Add test for ambiguous associated item
bd44c39 
The `#[pyclass]` macro implements `IntoPyObject` for the annotated enum.
When the enum has any of `Error`, `Output` or `Target` as members, this
clashes with the associated types of `IntoPyObject`.

This also happens when deriving `IntoPyObject` directly.
@LilyFoote LilyFoote force-pushed the fix-ambiguous-associated-item-error branch from d7d5b54 to 5335b28 Compare November 23, 2024 18:19
@LilyFoote
Fix #4723: ambiguous associated item in #[pyclass]
f82ca32 
This uses the fix described in rust-lang/rust#57644

Also apply fix to `#[derive(IntoPyObject)]`.
@LilyFoote LilyFoote force-pushed the fix-ambiguous-associated-item-error branch from 5335b28 to f82ca32 Compare November 23, 2024 19:41
davidhewitt
davidhewitt approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this seems complete to me too 👍

@davidhewitt davidhewitt added this pull request to the merge queue Nov 23, 2024
Merged via the queue into main with commit 9681b54 Nov 23, 2024
46 checks passed
@davidhewitt davidhewitt deleted the fix-ambiguous-associated-item-error branch November 23, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

@alex alex alex approved these changes

Assignees

@LilyFoote LilyFoote

Labels
bugfix rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ambiguous associated item 'Error' since 0.23
4 participants
@LilyFoote @alex @davidhewitt @Icxolu