Allow setting the module name for a pyclass #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #474, this PR adds an argument for
#[pyclass]
that lets the user specify the name of the module the class is part of. I also added the right module for all builtin types (eitherbuiltins
ordatetime
), with a few tests.Maintenance
cargo fmt
(This is checked by travis ci) ✅cargo clippy
and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)You might want to run
tox
(pip install tox
) locally to check compatibility with all supported python versions. If you're using linux or mac you might find the Makefile helpful for testing.