Use existing fields and methods before calling custom __getattr__ #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Jun 6, 2019
Previously, defining `__getattr__` would override all existing fields and methods. This changes it to behave like a `__getattr__` method defined in python, i.e. the custom method is only called if there isn't a field or method of that name
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=========================================
+ Coverage 87.52% 87.8% +0.28%
=========================================
Files 65 65
Lines 3422 3435 +13
=========================================
+ Hits 2995 3016 +21
+ Misses 427 419 -8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=========================================
+ Coverage 87.52% 87.8% +0.28%
=========================================
Files 65 65
Lines 3422 3435 +13
=========================================
+ Hits 2995 3016 +21
+ Misses 427 419 -8
Continue to review full report at Codecov.
|
|
Rebased and added a test. |
|
Thank for adding the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, defining
__getattr__would override all existing fields and methods. This changes it to behave like a__getattr__method defined in python, i.e. the custom method is only called if there isn't a field or method of that name.