Skip to content

If the bare abi3 feature is requested on a too-new Python, fall back to the maximum supported abi3 #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

alex
Copy link
Contributor

@alex alex commented May 14, 2025

Fixes #5093

@alex
Copy link
Contributor Author

alex commented May 14, 2025

untested because I don't have a 3.14 handy locally :-)

@alex
Copy link
Contributor Author

alex commented May 14, 2025

pyca/cryptography#12900 demonstrates this working. not sure how to write a test

@davidhewitt
Copy link
Member

Thanks & sorry for the slow reply!

I think it should be able to test this as part of the test-version-limits job, which manipulates the config file and then runs cargo check.

@alex
Copy link
Contributor Author

alex commented May 30, 2025

good call, easy!

@davidhewitt davidhewitt enabled auto-merge May 30, 2025 17:03
@davidhewitt davidhewitt added this pull request to the merge queue May 30, 2025
Merged via the queue into PyO3:main with commit 8373f45 May 30, 2025
44 of 45 checks passed
@alex alex deleted the abi3-version branch May 30, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting in-development Python versions
2 participants