Skip to content

ci: skip fragment checking in links for now #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

ci: skip fragment checking in links for now #5214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,22 +509,15 @@ def check_guide(session: nox.Session):
for key, value in remaps.items():
remap_args.extend(("--remap", f"{key} {value}"))

# some http URL fragments fail to be loaded (needs javascript?)
lychee_exclusions = [
"https://github.com/PyO3/pyo3/issues/1800#issuecomment-906786649",
"https://docs.rs/parking_lot/latest/parking_lot/type.Mutex.html#method.lock_arc",
"https://github.com/PyO3/pyo3/issues/1517#issuecomment-808664021",
"https://github.com/PyO3/maturin/blob/0dee40510083c03607834c821eea76964140a126/Readme.md#mixed-rustpython-projects",
]

# check all links in the guide
_run(
session,
"lychee",
"--include-fragments",
# FIXME: would be nice to use `--include-fragments` here, but we've had
# a lot of flaky failures from it - see https://github.com/lycheeverse/lychee/issues/1746
# "--include-fragments",
str(PYO3_GUIDE_SRC),
*remap_args,
"--exclude=" + "|".join(lychee_exclusions),
"--accept=200,429",
*session.posargs,
)
Expand Down
Loading