Skip to content

soundness for capsule reference and name #5474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 16, 2025
Merged

soundness for capsule reference and name #5474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0e81a79
Add safer methods to PyCapsule that check the capsule name
honzasp Sep 26, 2025
3b7fba6
soundness for `reference` and `name`
davidhewitt Sep 27, 2025
a363e66
remove `reference_checked`
davidhewitt Sep 28, 2025
cc40be6
clippy
davidhewitt Sep 28, 2025
0d89ed1
review feedback
davidhewitt Oct 9, 2025
d518732
SAFETY notes on unsafe blocks
davidhewitt Oct 10, 2025
8f1f19c
return capsule name as `CapsuleName` struct
davidhewitt Oct 11, 2025
d8ffff7
update newsfragment
davidhewitt Oct 11, 2025
09264fc
review feedback
davidhewitt Oct 15, 2025
d8414f3
typo
davidhewitt Oct 15, 2025
ffb849b
clippy
davidhewitt Oct 15, 2025
e1838bc
fingers crossed...
davidhewitt Oct 15, 2025
c030042
Update src/types/capsule.rs
davidhewitt Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/5474.added.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
added checked methods into `PyCapsuleMethods`: `pointer_checked()`, `is_valid_checked()`
3 changes: 3 additions & 0 deletions newsfragments/5474.changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Deprecate unchecked `PyCapsuleMethods`: `pointer()`, `reference()`, `is_valid()`
Reduce lifetime of return value in `PyCapsuleMethods::reference`
`PyCapsuleMethods::name` now returns `CapsuleName` wrapper instead of `&CStr`.
Loading
Loading