add #[pyclass(from_py_object)] to opt-in to a FromPyObject impl
#5506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
force-pushed
the
pyclass-from-py-object
branch
from
1114d82 to
4dca94c
Compare
Icxolu
force-pushed
the
pyclass-from-py-object
branch
from
4dca94c to
688f84d
Compare
davidhewitt
approved these changes
Oct 10, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this LGTM.
So the idea is to merge this flag into 0.27, and then in a follow up (probably in 0.28) start phasing in a requirement that one of these two flags is set?
Contributor
Author
That is the idea, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5488
This introduces the
#[pyclass(from_py_object)]option for pyclass, to opt-in to extraction of pyclasses by value. This uses the same approach as the blanket impl that we are phasing out and thus requires the pyclass to beClone.Ref #5419