Expose types::iterator::PySendResult in types module #5539
Conversation
PyIterator::send is a public method but the returned values are not usable while `PySendResult` is not public. Making it public allows callers to match on the result and access the wrapped values.
|
Not sure of the usual workflow here, would you prefer multiple commits to be squashed and rebased in the PR or are they all squashed and merged if/when the PR is closed and individual commits are easier to review? |
|
Tnx!
This is fine. It will get squashed on merge anyway. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This looks like a transient failure unrelated to the change |
|
Almost certainly caused by this morning's AWS incident. |
* Expose types::iterator::PySendResult in types module PyIterator::send is a public method but the returned values are not usable while `PySendResult` is not public. Making it public allows callers to match on the result and access the wrapped values. * Gate export of PySendResult behind Py_3_10 * Document PySendResult and add newsfragment
* Expose types::iterator::PySendResult in types module PyIterator::send is a public method but the returned values are not usable while `PySendResult` is not public. Making it public allows callers to match on the result and access the wrapped values. * Gate export of PySendResult behind Py_3_10 * Document PySendResult and add newsfragment
4 participants
PyIterator::send is a public method but the returned values are not
usable while
PySendResultis not public. Making it public allowscallers to match on the result and access the wrapped values.