Fix index error in parameter conversion codes #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
commented
Oct 15, 2019
| .iter() | ||
| .enumerate() | ||
| .map(|(pos, _)| syn::Ident::new(&format!("arg{}", pos), Span::call_site())) | ||
| (0..spec.args.len()) |
There was a problem hiding this comment.
This is just refactoring, not related to the core of this PR.
kngwyu
commented
Oct 15, 2019
| @@ -461,15 +455,15 @@ pub fn impl_arg_params(spec: &FnSpec<'_>, body: TokenStream) -> TokenStream { | |||
|
|
|||
| let accept_args = bool_to_ident(spec.accept_args()); | |||
| let accept_kwargs = bool_to_ident(spec.accept_kwargs()); | |||
|
|
|||
| let num_normal_params = params.len(); | |||
There was a problem hiding this comment.
This is just refactoring, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated codes for argument conversion looks like
This PR fix this index not to increase for *args and **kwargs.
I hope this PR would fix our build status for the latest nightly.