Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specialization from some blanket impls #713

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Remove specialization from some blanket impls #713

merged 2 commits into from
Jan 7, 2020

Conversation

davidhewitt
Copy link
Member

While getting my head around #697 I noticed that we seem to no longer need specialization for these blanket impls.

kngwyu
kngwyu approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kngwyu
Copy link
Member

kngwyu commented Jan 7, 2020

Thank you!

@kngwyu kngwyu merged commit 18440d7 into PyO3:master Jan 7, 2020
@davidhewitt davidhewitt deleted the remove-specializations branch January 7, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu