Simplify callback code using callback_body! macro #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While finishing off #797 I had an idea how to remove the
run_callback
function and instead use a macro. This had three benefits:run_callback
no longer appears in the stack trace when panickingGILPool::new()
,pool.python()
callback::convert()
As a result, all callback code now uses this macro instead of
run_callback
, making all callback code shorter and easier to read 😄