Allow #[getter] and #[setter] functions to take PyRef #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #837
I rewrote the proc_macro code to allow
#[getter]
and#[setter]
functions to take&self
as well asPyRef<Self>
etc.It might also be possible to make a similar change so that all
#[pyproto]
methods can also choose beteween&self
,&mut self
,PyRef<Self>
, etc. but this change was necessary first so I began with this PR.