Fix README.md #146
Merged
Fix README.md #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pyo3 version in examples.
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Mar 17, 2021
As a conclusion to PyO3/rust-numpy#146 the MSRV for rust-numpy was defined as matching PyO3 and being 1.41.1. The rust-numpy 0.13.1 release handled this and relaxed it's dependency on upstream dependencies (namely ndarray) to enable building with rust 1.41.1. Since rust 1.41.1 is what is shipped with Debian buster it will work for retworkx (so we don't block piwheels which relies on the debian rustc package). This commit bumps the rust-numpy version to the latest release and correspondingly bumps the MSRV to match at 1.41.1 which also unblocks the use of the latest PyO3 release.
mtreinish
added a commit
to mtreinish/retworkx
that referenced
this pull request
Mar 17, 2021
As a conclusion to PyO3/rust-numpy#146 the MSRV for rust-numpy was defined as matching PyO3 and being 1.41.1. The rust-numpy 0.13.1 release handled this and relaxed it's dependency on upstream dependencies (namely ndarray) to enable building with rust 1.41.1. Since rust 1.41.1 is what is shipped with Debian buster it will work for retworkx (so we don't block piwheels which relies on the debian rustc package). This commit bumps the rust-numpy version to the latest release and correspondingly bumps the MSRV to match at 1.41.1 which also unblocks the use of the latest PyO3 release.
mtreinish
added a commit
to Qiskit/rustworkx
that referenced
this pull request
Mar 17, 2021
* Revert "Revert "Bump pyo3 from 0.12.4 to 0.13.1 (#224)"" This commit restores the PyO3, rust-numpy, and ndarray bump to the latest versions. This was previously reverted in #237 to avoid the increase in the minimum supported rust version to enable builds on piwheels. However, now that 0.8.0 has been released I think it's fine to bump now. This reverts commit 3beb8fb. * Relax msrv to 1.42.0 * Update bump-msrv-d581a8cbeff8915b.yaml * Update README.md * Use rust-numpy 0.13.1 and bumpy MSRV to 1.41.1 As a conclusion to PyO3/rust-numpy#146 the MSRV for rust-numpy was defined as matching PyO3 and being 1.41.1. The rust-numpy 0.13.1 release handled this and relaxed it's dependency on upstream dependencies (namely ndarray) to enable building with rust 1.41.1. Since rust 1.41.1 is what is shipped with Debian buster it will work for retworkx (so we don't block piwheels which relies on the debian rustc package). This commit bumps the rust-numpy version to the latest release and correspondingly bumps the MSRV to match at 1.41.1 which also unblocks the use of the latest PyO3 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pyo3 version in examples.