Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax MSRV version to 1.41.1 and test it in CI #177

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Mar 15, 2021

Fixes #176. If this succeeds, patch release should follow.

@kngwyu kngwyu force-pushed the update-msrv branch 4 times, most recently from c92215d to 197a93c Compare March 15, 2021 17:12
@kngwyu
Copy link
Member Author

kngwyu commented Mar 15, 2021

Oops, it looks like that ndarray=0.14 is selected for rust-numpy:
https://github.com/PyO3/rust-numpy/pull/177/checks?check_run_id=2114810876

@kngwyu kngwyu force-pushed the update-msrv branch 4 times, most recently from f9076db to cdbe759 Compare March 16, 2021 06:04
@kngwyu
Copy link
Member Author

kngwyu commented Mar 16, 2021

@mtreinish @davidhewitt
Sorry for this noisy notification, but do you have any idea for successfully compiling the example with ndarray 0.13.1?
Since cargo resolves ndarray=0.14, I am now manually editing the generated Cargo.lock by a Python script.
Also, -Z minimal-versions fails due to a dependency (ghost=0.1.0 requires older syn and quote, which causes a problem).

@messense
Copy link
Member

Have you tried cargo update -p ndarray --precise 0.13.1 ?

@davidhewitt
Copy link
Member

(Sorry, deleted other comment; it was wrong and unhelpful!)

Have you tried cargo update -p ndarray --precise 0.13.1 ?

Ah, this works, but only if Cargo.toml for simple-extension is modified to target ndarray = "0.13" and the [workspace] section is removed from the root Cargo.toml. (With the [workspace] section present cargo tries to unify the version across all examples, which doesn't work because the linalg example still requires 0.14.)

@kngwyu
Copy link
Member Author

kngwyu commented Mar 16, 2021

Have you tried cargo update -p ndarray --precise 0.13.1 ?

Many thanks for this. cargo update -p ndarray:0.14.0 --precise 0.13.1 worked.

but only if ...

Yeah, I resolve the problem by running the example outside the rust-numpy directory on CI.

(Deleted comment)

rust-lang/cargo#5340 suggests that it's discouraged to have such dependencies.

Yeah, I think this is bad, but I believe MSRV is a more serious problem.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSRV for rust-numpy
3 participants