Avoid raw pointers in SliceBox and make the Send bound explicit #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #189. I think the main benefit besides removing two unsafe usages is propagating the
Send
bound which seems to imply thatElement
must indeed beSend
to be wrapped withinSliceBox
and managed by Python.Taking this a bit further, there seems to be nothing slice or box specific about
SliceBox
, i.e. we could just as well have awhich does not care about its contents at all, that is besides making it possible for Python to indirectly call
T
'sDrop
implementation.