-
Notifications
You must be signed in to change notification settings - Fork 121
Drop the re-exports of PyMem_Raw* calls as those are not available using the limited API. #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This must definitely be resolved before releasing 0.16 as the limited API is otherwise unusable with |
You can use It should be publicly visible, looks like we have a docs bug. |
We can do that, but I am not sure this is the right thing to do: This will add the build time costs of a build script to this crate to enable re-exports which were made mainly for consistency with the C headers, not because of a concrete use case. (And if that use case has emerged in the mean time, it will have problems working with the limited API even if we make the re-exports available conditionally.) |
I think the problem is that the |
I added a commit implementing this, but as written above I would prefer to not merge it due to the unclear use case of these re-exports. (Someone who does really need these can still use them directly from PyO3 after looking into the NumPy headers.) |
Ok, I understand now. Sorry for my short response before - let's go back to removing these re-exports (we can always leave a comment in |
Will do an explicit revert to leave a paper trail and add such a comment. |
…ing the limited API.
…the enabled PyO3 features.
da23e3e
to
489aa26
Compare
…t where to find the underlying PyO3 functions. This reverts commit 712626b.
489aa26
to
ea410ca
Compare
Noticed this when preparing to upgrade an internal project at work. I opted to remove the re-exports for now as I do not see an easy option to make their presence dependent on whether PyO3 was built against the limited API or not.