Mismatched behavior between PyArrayLike1 and PyArrayLike2 when used with floats #520
+57
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to resolve issue #444.
Current behavior
When
PyArrayLike1<f32, TypeMustMatch>is used, arrays constructed usingnp.array([...], dtype='float64')are converted implicitly tof32. This results in a new allocation and a truncation error.Conversely,
PyArrayLike2<f32, TypeMustMatch>behaves differently: arrays constructed usingnp.array([[...], ...], dtype='float64')are not accepted as valid values.I think the current behavior creates confusion and is not consistent with the current documentation, which states:
New behavior
The condition in the following portion of code has been changed to avoid the implicit conversion introduced by
Borrowed::extractcall. The conversion should be performed only when the choice ofDallows type changes or the input object is not a numpy ndarray.rust-numpy/src/array_like.rs
Lines 154 to 163 in 78d5e8d