Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not return result in as_array & as_slice #75

Merged
merged 2 commits into from
Oct 28, 2018

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Oct 25, 2018

  1. If we construct PyArray via Rust API
    It's already type checked.
  2. If we construct PyArray in Python
    It's type checked when FromPyObject::extract.

In both cases PyArray is already type checked when we can apply methods to it.
So I think we don't have to do type check in as_array and as_slice, though it's left as assertion.

@kngwyu kngwyu requested a review from termoshtt October 25, 2018 13:12
@kngwyu
Copy link
Member Author

kngwyu commented Oct 26, 2018

Now CI fails due to rust-lang/rust#55380

@kngwyu kngwyu merged commit 2a662f5 into PyO3:master Oct 28, 2018
@kngwyu kngwyu deleted the as_return_noresult branch October 28, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant