With latest nightly rust, builds failing due to changes in cargo output

[alex]

I'm currently seeing all builds failing on the latest nightly Rust with:

  error: Rust build failed; unable to find any cdylib or dylib build artifacts

This error comes from: https://github.com/PyO3/setuptools-rust/blob/main/setuptools_rust/build.py#L301-L310

The cause appears to be that the format of the package_id variable changed. On stable, package_id for me is: cryptography-rust 0.1.0 (path+file:///Users/alex_gaynor/projects/cryptography/src/rust), while on nightly, the package_id is path+file:///Users/alex_gaynor/projects/cryptography/src/rust#cryptography-rust@0.1.0.

However, the format of package IDs found in the cargo JSON build output is unchanged, which results in _find_cargo_artifacts no longer matching things.

I'm not sure if this is a cargo bug or a setuptools-rust bug.

[alex]

I think rust-lang/cargo#13311 might be the cause

[alex]

Actually, more likely rust-lang/cargo#12914

[alex]

It looks like these landed in rustc in seperate bumps:

• Update cargo rust-lang/rust#120036
• Update cargo rust-lang/rust#120071

And I believe these were split across separate nightlies, so it is possible this will be resolved in the next nightly bump.

[davidhewitt]

This is also affecting maturin, I guess we see if it resolves again tomorrow then?

[alex]

That's my plan

…

On Thu, Jan 18, 2024, 3:33 PM David Hewitt ***@***.***> wrote: This is also affecting maturin, I guess we see if it resolves again tomorrow then? — Reply to this email directly, view it on GitHub <#398 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBA6FZ5EX526D7LCGZTYPGBKBAVCNFSM6AAAAABCAFWZ7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGE3DGOJSGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[alex]

Ok we're good with the nightly that came out a few minutes ago. Declaring victory here.