fix: handle mismatched dim lengths during rechunking (take 2) #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395 and #381 .
@lkstrp
We stumbled over your changes in #395 today starting from some custom code.
If
ds
has an unchunked time dimension you getand then
retrieves the letter "a", which breaks
n.chunk(...)
.I think you meant to check for whether there are chunks (which are always given as a tuple) and then use the leading chunksize in that case.
@geiges Thanks for the report.
Checklist
doc
.environment.yaml
,environment_docs.yaml
andsetup.py
(if applicable).doc/release_notes.rst
of the upcoming release is included.