fix: unpin numpy<2 for python>3.10 #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@FabianHofmann simple solution is to just keep numpy<2 for python 3.9 and 3.10 as these encounter a segfault on ubuntu when running pytest otherwise... which may be quite time consuming to try and debug. I'm not sure it's worth it for these soon to be unsupported python versions? Let me know what you think |
ollie-bell
changed the title
ollie-bell
changed the title
Contributor
Author
|
Think this is good to go! |
FabianHofmann
approved these changes
Feb 9, 2025
Collaborator
|
Great Job @ollie-bell |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove numpy<2 pin for python>3.10
Taking over from #332