-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump github actions versions #171
Conversation
@afuetterer Thank you! Would you mind having a look to the failed CI? We just need to pass a distribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
I see. Actually I did not run the workflow in my fork and just assumed it would work. Sorry for that. You need to provide a distribution: Any preferred choice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess temurin should be fine
Awesome, thanks. |
@@ -13,7 +13,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this one. Should this be actions/checkout@v4
as well? Using master is not recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you want to create another PR for that, that would be appreciated! The CI here has not been touched for a while. The one in the PyPSA repo has been updated recently if you want to check it out as well.
Closes # (if applicable).
Change proposed in this Pull Request
This PR bumps the GitHub Actions versions in your CI workflows. This will get rid of warnings in the annotations like
Node.js 16 actions are deprecated
, see e.g. : https://github.com/PyPSA/powerplantmatching/actions/runs/9656832310I did not open an issue first, because the change is trivial. What do you think?
Type of change
Checklist
doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contributiondoc/
.