Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump github actions versions #171

Merged
merged 2 commits into from
Jun 27, 2024
Merged

ci: bump github actions versions #171

merged 2 commits into from
Jun 27, 2024

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Jun 27, 2024

Closes # (if applicable).

Change proposed in this Pull Request

This PR bumps the GitHub Actions versions in your CI workflows. This will get rid of warnings in the annotations like Node.js 16 actions are deprecated, see e.g. : https://github.com/PyPSA/powerplantmatching/actions/runs/9656832310

I did not open an issue first, because the change is trivial. What do you think?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@lkstrp
Copy link
Member

lkstrp commented Jun 27, 2024

@afuetterer Thank you!

Would you mind having a look to the failed CI? We just need to pass a distribution

Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@afuetterer
Copy link
Contributor Author

I see. Actually I did not run the workflow in my fork and just assumed it would work. Sorry for that.

You need to provide a distribution:
https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

Any preferred choice?

Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess temurin should be fine

@lkstrp lkstrp merged commit 5abf5f4 into PyPSA:master Jun 27, 2024
2 checks passed
@afuetterer
Copy link
Contributor Author

Awesome, thanks.

@afuetterer afuetterer deleted the ci branch June 27, 2024 14:14
@@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this one. Should this be actions/checkout@v4 as well? Using master is not recommended.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if you want to create another PR for that, that would be appreciated! The CI here has not been touched for a while. The one in the PyPSA repo has been updated recently if you want to check it out as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants