Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Correction Factor #225

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Solar Correction Factor #225

merged 5 commits into from
Oct 9, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Oct 8, 2024

Issue

Addressing #224

Adding a correction factor for solar to correction_factor = 0.86 to limit the electricity generation from solar.
Modelling to target so 2020 results match the historical data.

Validation

Full load hours before PR: 1071.5
Full load hours with PR: 921.3

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
    not applicable
  • One or several figures that validate the changes in the PR have been posted as a comment
    not applicable
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link

github-actions bot commented Oct 8, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main failed in: retrieve_ariadne_database
  • fix_solar_cf failed in: retrieve_ariadne_database

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix_solar_cf (c0e7aa2) with main (3d2a80e).
Branch is 5 commits ahead and 1 commits behind.
Last updated on 2024-10-09 17:40:43 CEST.

@toniseibold toniseibold requested a review from lindnemi October 8, 2024 11:25
@toniseibold toniseibold marked this pull request as ready for review October 8, 2024 11:29
@toniseibold
Copy link
Contributor Author

@lindnemi Can you please comment the source for the Fraunhofer ISE data :)

@lindnemi lindnemi merged commit 3d2a80e into main Oct 9, 2024
2 checks passed
toniseibold added a commit that referenced this pull request Oct 10, 2024
* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>
lindnemi added a commit that referenced this pull request Oct 17, 2024
* report transmission/distribution grid capacity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* force offshore wind from NEP 2023 at correct connection point (#191)

* force offshore wind from NEP 2023 at correct connection point

Projects for offshore wind connection in the North and Baltic Seas are
read in and then (in a configurable way) forced into the network with
the correction connection point. The default is only to do this for
the projects planned until 2030, which mostly already have final
investment decisions.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix strange input error by adding the wildcard_constraints back in

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add comment

* do not specify 2030 max offwind capacity in scenarios

* force projects in 2025, increase 2025 minimum for offwind, add AC projects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* distinguish DC / AC more robustly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing Trassenlängen

* handle offwind connection cost in modify_prenetwork

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* Removing custom electrolysis costs (#229)

* removing custom electrolysis costs

* Documenting changes

---------

Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Correct electricity net generation data in validation (#227)

* correct elec val data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Solar Correction Factor (#225)

* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* watch pypsa-eur data folder for changes (#232)

* watch pypsa-eur data folder for changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* removing grid addtions from exporter

* changing prefix

* fix and export unsustainable BtL

* export more transport variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* include capacity additions

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* report NEP investments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change capital_cost of projections after optimization

* simplify code

* update submodule (order of transmission projects)

* fix typos

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
toniseibold added a commit to toniseibold/ARCHIVE-pypsa-de-import that referenced this pull request Oct 22, 2024
* report transmission/distribution grid capacity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* force offshore wind from NEP 2023 at correct connection point (PyPSA#191)

* force offshore wind from NEP 2023 at correct connection point

Projects for offshore wind connection in the North and Baltic Seas are
read in and then (in a configurable way) forced into the network with
the correction connection point. The default is only to do this for
the projects planned until 2030, which mostly already have final
investment decisions.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix strange input error by adding the wildcard_constraints back in

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add comment

* do not specify 2030 max offwind capacity in scenarios

* force projects in 2025, increase 2025 minimum for offwind, add AC projects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* distinguish DC / AC more robustly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing Trassenlängen

* handle offwind connection cost in modify_prenetwork

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* Removing custom electrolysis costs (PyPSA#229)

* removing custom electrolysis costs

* Documenting changes

---------

Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Correct electricity net generation data in validation (PyPSA#227)

* correct elec val data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Solar Correction Factor (PyPSA#225)

* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* watch pypsa-eur data folder for changes (PyPSA#232)

* watch pypsa-eur data folder for changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* removing grid addtions from exporter

* changing prefix

* fix and export unsustainable BtL

* export more transport variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* include capacity additions

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* report NEP investments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change capital_cost of projections after optimization

* simplify code

* update submodule (order of transmission projects)

* fix typos

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
@toniseibold toniseibold deleted the fix_solar_cf branch October 25, 2024 10:59
toniseibold added a commit to toniseibold/ARCHIVE-pypsa-de-import that referenced this pull request Oct 25, 2024
* report transmission/distribution grid capacity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* force offshore wind from NEP 2023 at correct connection point (PyPSA#191)

* force offshore wind from NEP 2023 at correct connection point

Projects for offshore wind connection in the North and Baltic Seas are
read in and then (in a configurable way) forced into the network with
the correction connection point. The default is only to do this for
the projects planned until 2030, which mostly already have final
investment decisions.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix strange input error by adding the wildcard_constraints back in

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add comment

* do not specify 2030 max offwind capacity in scenarios

* force projects in 2025, increase 2025 minimum for offwind, add AC projects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* distinguish DC / AC more robustly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing Trassenlängen

* handle offwind connection cost in modify_prenetwork

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* Removing custom electrolysis costs (PyPSA#229)

* removing custom electrolysis costs

* Documenting changes

---------

Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Correct electricity net generation data in validation (PyPSA#227)

* correct elec val data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Solar Correction Factor (PyPSA#225)

* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* watch pypsa-eur data folder for changes (PyPSA#232)

* watch pypsa-eur data folder for changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* removing grid addtions from exporter

* changing prefix

* fix and export unsustainable BtL

* export more transport variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* include capacity additions

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* report NEP investments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change capital_cost of projections after optimization

* simplify code

* update submodule (order of transmission projects)

* fix typos

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
JulianGeis added a commit to JulianGeis/pypsa-ariadne-pricing that referenced this pull request Oct 29, 2024
* report transmission/distribution grid capacity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* force offshore wind from NEP 2023 at correct connection point (PyPSA#191)

* force offshore wind from NEP 2023 at correct connection point

Projects for offshore wind connection in the North and Baltic Seas are
read in and then (in a configurable way) forced into the network with
the correction connection point. The default is only to do this for
the projects planned until 2030, which mostly already have final
investment decisions.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix strange input error by adding the wildcard_constraints back in

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add comment

* do not specify 2030 max offwind capacity in scenarios

* force projects in 2025, increase 2025 minimum for offwind, add AC projects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* distinguish DC / AC more robustly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing Trassenlängen

* handle offwind connection cost in modify_prenetwork

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* Removing custom electrolysis costs (PyPSA#229)

* removing custom electrolysis costs

* Documenting changes

---------

Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Correct electricity net generation data in validation (PyPSA#227)

* correct elec val data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Solar Correction Factor (PyPSA#225)

* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* watch pypsa-eur data folder for changes (PyPSA#232)

* watch pypsa-eur data folder for changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* removing grid addtions from exporter

* changing prefix

* fix and export unsustainable BtL

* export more transport variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* include capacity additions

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* report NEP investments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change capital_cost of projections after optimization

* simplify code

* update submodule (order of transmission projects)

* fix typos

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
toniseibold added a commit to toniseibold/ARCHIVE-pypsa-de-import that referenced this pull request Nov 1, 2024
* report transmission/distribution grid capacity

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* force offshore wind from NEP 2023 at correct connection point (PyPSA#191)

* force offshore wind from NEP 2023 at correct connection point

Projects for offshore wind connection in the North and Baltic Seas are
read in and then (in a configurable way) forced into the network with
the correction connection point. The default is only to do this for
the projects planned until 2030, which mostly already have final
investment decisions.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix strange input error by adding the wildcard_constraints back in

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add comment

* do not specify 2030 max offwind capacity in scenarios

* force projects in 2025, increase 2025 minimum for offwind, add AC projects

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* distinguish DC / AC more robustly

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing Trassenlängen

* handle offwind connection cost in modify_prenetwork

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* Removing custom electrolysis costs (PyPSA#229)

* removing custom electrolysis costs

* Documenting changes

---------

Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Correct electricity net generation data in validation (PyPSA#227)

* correct elec val data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>

* Solar Correction Factor (PyPSA#225)

* adding correction_factor for solar and solar-hsat

* Documenting changes

* update correction factor to Fraunhofer ISE data

* add source for factor

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>

* watch pypsa-eur data folder for changes (PyPSA#232)

* watch pypsa-eur data folder for changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* removing grid addtions from exporter

* changing prefix

* fix and export unsustainable BtL

* export more transport variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* include capacity additions

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* report NEP investments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change capital_cost of projections after optimization

* simplify code

* update submodule (order of transmission projects)

* fix typos

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tom Brown <tom@nworbmot.org>
Co-authored-by: Michael Lindner <michaellindner@posteo.de>
Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Co-authored-by: Julian Geis <j.geis@tu-berlin.de>
@lindnemi lindnemi mentioned this pull request Nov 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants