-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pellet boilers for decentral use #255
Conversation
@millingermarkus great, thanks a lot! Are your PRs ready for review or are you planing to make further changes? |
You are welcome, they are ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @millingermarkus for breaking all your changes into small PRs. Looks really good, I only have two remaining questions
@@ -1521,6 +1521,22 @@ def add_heat(n, costs): | |||
capital_cost=costs.at[key, 'efficiency'] * costs.at[key, 'fixed'], | |||
lifetime=costs.at[key, 'lifetime'] | |||
) | |||
|
|||
if options["biomass_boiler"] and name not in ["urban central"]: | |||
#TODO: Add surcharge for pellets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this TODO still open?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, but not so urgent in my mind. A surcharge improves cost accuracy but this tech plays a very minor role in my runs so far anyway. I'll add the pelletisation cost to technology data and refer to it here when I get there.
bus2="co2 atmosphere", | ||
carrier=name + " biomass boiler", | ||
efficiency=costs.at['biomass boiler', 'efficiency'], | ||
efficiency2=costs.at['solid biomass', 'CO2 intensity']-costs.at['solid biomass', 'CO2 intensity'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the biomass boilers do not emit any CO2 are they? If not, one can remove the connection to bus2
and efficiency2
when adding them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, no net emissions as long as biomass is assumed to be carbon neutral. So yes this connection is technically not necessary (but maybe good to keep for consistency with other biomass techs?). I think both are ok, you decide!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I am going to remove it for now to be consistent with how we implement the biomass CHPs for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more question @millingermarkus the costs and efficiencies for the biomass boilers should they be solid biomass boiler steam
in the technology-data or did I missed something when pulling your changes into the main code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that tech was missing in the main technology data, I made a pull request now: PyPSA/technology-data#61
No description provided.