Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug myopic co2 #256

Merged
merged 10 commits into from
Aug 9, 2022
Merged

Fix bug myopic co2 #256

merged 10 commits into from
Aug 9, 2022

Conversation

lisazeyen
Copy link
Collaborator

This PR should fix three bugs

  1. the option to limit the CO2 emissions by e.g. cb40ex0 as a sector_opts was not working anymore due to changes in the build_energy_totals.py script
  2. by changing the grouping_years in this PR here fix grouping years list issue caused by newer powerplant database #240 to [1980, 1985, 1990, 1995, 2000, 2005, 2010, 2015, 2020, 2025, 2030] two issues arise in the add_existing_baseyear.py script:
  • components with same names where added to the network (e.g. for planning horizon 2020 existing infrastructure for solar was added with the same name as the extendable assets for this planning horizon)
  • the existing heating infrastructure data is not taken from the powerplant matching and should be therefore evenly distributed over the last 25 years (old grouping_years, not including future years 2025 and 2030)
  1. fixes in plot_summary for myopic code and also removing update_config_with_sector_opts introduced in option to specify any config through sector opts with CF:<label>:<value> #251 since sector opts is not a wildcard for this rule

@lisazeyen lisazeyen requested a review from fneum August 1, 2022 14:17
@lisazeyen
Copy link
Collaborator Author

@energyLS

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. Just some polishing:

scripts/plot_summary.py Outdated Show resolved Hide resolved
scripts/plot_summary.py Outdated Show resolved Hide resolved
scripts/plot_summary.py Show resolved Hide resolved
scripts/add_existing_baseyear.py Outdated Show resolved Hide resolved
scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
@lisazeyen
Copy link
Collaborator Author

Let's wait with merging until @Irieo and I had a look at the biomass CHPs

@lisazeyen lisazeyen merged commit 3daff49 into master Aug 9, 2022
@lisazeyen lisazeyen deleted the fix-bug-myopic-co2 branch August 9, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants