-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use powerplantmatching IRENASTAT for renewable capacities in add_existing_baseyear
#1018
Conversation
I agree, @koen-vg. The link in |
PyPSA/powerplantmatching#157 is merged and included in v0.5.13 of powerplantmatching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only requires powerplantmatching version bump in environment.yaml
Needed in order to get renewable capacities from pm.IRENA newer than 2020; updated to 2023 in version 0.5.13
Great, easy enough to bump the version :) |
Guess it wasn't that easy, haha, powerplantmatching 0.5.13 will need a little bit of time until it's installable. |
It does now seem to work. |
Changes proposed in this Pull Request
I wanted to update existing renewable capacities to 2023 values recently made available by IRENA. But there seems to be some duplicated effort on this front within the PyPSA umbrella: powerplantmatching has information of renewable capacities from IRENA, and the same data is downloaded through a separate path in
retrieve_irena.py
.As nice of an improvement #756 is, I would propose cutting out
retrieve_irena.py
altogether and using the IRENA data retrieved by powerplantmatching directly. This is implemented in the current PR, achieving the same functionality as before with much less code all in all.To avoid a regression in terms of data for recent years, this PR should only be merged once PyPSA/powerplantmatching#157 is merged, and then should be combined with a version bump of the powerplantmatching dependency.
In the future, data on existing renewable capacities can be updated simply by updating powerplantmatching and bumping the version in pypsa-eur. This will then transparently filter through to both places where existing renewable capacities are added to network in pypsa-eur, namely in
add_electricity.py
and inadd_existing_baseyear.py
. Having these two scripts depend on different sources for the same data seems like a source of confusion and potential problems.Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.