Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow excluding files from shared_resources #1050

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented May 3, 2024

Changes proposed in this Pull Request

The scenario management has the config[run][shared_resources]. However, it is sometimes helpful to be able to exclude files that are changed for each scenario when setting config[run][shared_resources]=base.
Here the helpers function get_run_path now takes an additional list of files that should be excluded from the filesharing.
exclude accepts a list of strings, the string only needs to match the start of a filename since the function startswith() is used in the helpers function. E.g. "transport_data" would exclude both transport_data.csv and transport_data_{simpl}_{clusters}.csv from filesharing.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@toniseibold toniseibold marked this pull request as ready for review May 6, 2024 08:34
@fneum fneum added this to the v0.11.0 milestone May 12, 2024
@fneum fneum merged commit 8a45e66 into ariadne2 May 13, 2024
2 checks passed
@toniseibold toniseibold deleted the exclude_shared_resources branch June 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants