Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert hotfix for doubled renewable capacity #1092

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

lindnemi
Copy link
Contributor

@lindnemi lindnemi commented Jun 7, 2024

In myopic optimisation the renewable capacities were added twice. This has recently been noted in #1016, but before that already in #727 and more recently in #1029.

With #1080 the underlying cause has been addressed, and the estimation of renewable capacities in add_electricity has been disabled for myopic foresight (and i think for perfect foresight as well, was this intentional?).

However, before #1080, two hotfixes addressed the problems caused be the doubled renewable capacity, namely #728 and #1022.

This PR removes the hotfixes, which were now causing problems themselves when the grouping_year was equal to the baseyear.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lindnemi lindnemi requested a review from lisazeyen June 7, 2024 12:33
@lindnemi lindnemi merged commit 24b50e8 into master Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants