revert hotfix for doubled renewable capacity #1092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In myopic optimisation the renewable capacities were added twice. This has recently been noted in #1016, but before that already in #727 and more recently in #1029.
With #1080 the underlying cause has been addressed, and the estimation of renewable capacities in add_electricity has been disabled for myopic foresight (and i think for perfect foresight as well, was this intentional?).
However, before #1080, two hotfixes addressed the problems caused be the doubled renewable capacity, namely #728 and #1022.
This PR removes the hotfixes, which were now causing problems themselves when the grouping_year was equal to the baseyear.
Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.