Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make year selection more secure in transport data creation #1225

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

FabianHofmann
Copy link
Contributor

Extends on ad100c4 but for the future probably a bit more secure.

Also use index.unique instead of index.levels to avoid duplications and avoid some performance issues around lexsort

Closes #1218

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

use index.unique instead of index.levels where needed
@FabianHofmann FabianHofmann requested a review from fneum August 19, 2024 11:39
Copy link
Contributor

@lisazeyen lisazeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks all good! Just for the Swiss transport data I would suggest to stick with the hard coded numbers.

@lisazeyen lisazeyen merged commit 49053f3 into master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors around Switzerland
2 participants