-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update central heating temperatures based on Euroheat data and AGFW-Hauptbericht #1264
Conversation
Using Euroheat market outlook 2024 and AGFW-Hauptbericht
for more information, see https://pre-commit.ci
…polation function
…res' into update-central-heating-temperatures
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, this looks good to me. Results look plausible. Not merging as it is in draft mode.
The reason the tests fail is because ValueError: t_hot must be greater than t_cold
, which needs to be captured but is probably a small fix.
Merge at will once tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @amos-schledorn! Do you already have an idea what's causing the error thrown in the CI?
Currently, central heating forward and return temperatures are guesstimates. This PR applies data on typical forward temperatures from Euroheat's 2024 Market Outlook. Minimum forward temperatures and return temperatures are extrapolated based on German data from AGFW-Hauptebericht 2022.
The data itself is a config setting and exchangeable; the extrapolation of missing country data is introduced as a feature.
Changes proposed in this Pull Request
config.default
is updated such that Euroheat data is used for country-wise forward temperatures, with the exception of Germany ("up to 130C" in Euroheat data), where data from AGFW-Hauptbericht 2022 is used.build_central_heating_profiles.run.py
is modified such that:max_forward_temperature
values are replaced by average across all other countries and entrydefault
in (countries not present inconfig.max_forward_temperatures
).min_forward_temperature
/return_temperature
values (by default all but Germany) are extrapolated from average ratio betweenmax_forward_temperature
andmin_forward_temperature
/return_temperature
for those countries specified inmin_forward_temperature
(by default only Germany, from AGFW-Hauptbericht).Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.Testing
This config was used for testing:
The new supply temperatures are (for those countries in config):
For all countries:
Urban central heat mix before:
Urban central heat mix after:
Note
Bacteria growth might be a problem for low return temperatures, such as for Denmark. However, the DEA technology catalogue for district heating mentions low return temperatures (~35C) in several places - simply search for "return" in the PDF.
I would suggest not setting a floor value for now but confirming this with experts in the future.