Bug fix: simplify_network.py (simplify_links) - By adding preceding converter removal

[bobbyxng]

Changes proposed in this Pull Request

• @p-glaum and @bobbyxng
• Bug fix occuring when multiple DC links are connected to the same DC bus and the DC bus is connected to an AC bus via converter.
• Links were simplified in a wrong manner, leading to the DC bus being dropped, e.g. in the case of a TYNDP project connecting Sicily to mainland Italy.
• This does not impact simplification of DC links that consist of DC buses along the way, which are not connected to an AC bus via converter.
• Tested with osm-grid, transmission projects on, 45 buses and weekly resolution. solve_elec_networks converges.

Checklist

• I tested my contribution locally and it works as intended.
• Code and workflow changes are sufficiently documented.
• Changed dependencies are added to envs/environment.yaml.
• A release note doc/release_notes.rst is added.

[github-actions]

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison

Main branch	Feature branch

Files comparison

	Status	NRMSE	MAE (norm)
prices.csv	⚠️Changed	0.000	0.18
weighted_prices.csv	⚠️Changed	0.401	0.62
curtailment.csv	⚠️Changed	0.000	0.22
price_statistics.csv	⚠️Changed	0.017	0.19
metrics.csv	⚠️Changed	0.000	0.11
nodal_costs.csv	⚠️ NaN mismatch
nodal_supply_energy.csv	⚠️ NaN mismatch
nodal_cfs.csv	⚠️ NaN mismatch
nodal_capacities.csv	⚠️ NaN mismatch
cfs.csv	⚠️ NaN mismatch
market_values.csv	✅ Almost equal	0.013	0.04
supply.csv	✅ Almost equal	0.000	0.02
costs.csv	✅ Almost equal	0.001	0.01
capacities.csv	✅ Almost equal	0.001	0.02
supply_energy.csv	✅ Almost equal	0.000	0.01
energy.csv	✅ Almost equal	0.000	0.01

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks

Comparing fix-simplify-links (cb29a7e) with master (49ca406).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2024-10-22 16:07:25 CEST.