-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major improvement to OSM-based electricity grid (e.g. using relations, preserving substation locations) #1384
Open
bobbyxng
wants to merge
25
commits into
master
Choose a base branch
from
osm-relations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a1d076c
Implemented line merge over virtual bus functionality.
bobbyxng 0287872
Implemented: Aggregating identical lines, bus merging to stations, cr…
bobbyxng ce15373
Implemented: Mapping of lines to buses and extending lines to buses.
bobbyxng 77f77c8
Finished implementing converters and links.
bobbyxng 24145f7
Finished implementation of entirely new build_osm_network.py script.
bobbyxng 9aca61a
Merge branch 'master' into osm-interconnectors
bobbyxng fc5b36c
Updated configtables.
bobbyxng 43cf668
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] caf8eb9
Temporarily disabled tqdm in retrieve. Line splitting disabled as well.
bobbyxng 6b00178
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fb653fb
Implemented relations. Running, converging workflow.
bobbyxng b2c21f7
Added updated simplify_network.py
bobbyxng 2aefa9b
Cleaned up code.
bobbyxng 5420fec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9b24312
Updated doc
bobbyxng 4ef062f
Merge remote-tracking branch 'refs/remotes/origin/osm-relations' into…
bobbyxng 8aec857
Reactivated line splitting.
bobbyxng 13391d6
Updated build_osm_network.
bobbyxng 639eef7
Cleaned up code.
bobbyxng aca66fb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0cca562
Added 400 kV voltage level to config.default
bobbyxng b3fec47
Merge branch 'osm-relations' of https://github.com/pypsa/pypsa-eur in…
bobbyxng db2f593
Merge branch 'master' into osm-relations
bobbyxng e9f7798
Updated Zenodo link
bobbyxng c7c453d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -456,7 +456,8 @@ def _set_electrical_parameters_transformers(transformers, config): | |
|
||
## Add transformer parameters | ||
transformers["x"] = config.get("x", 0.1) | ||
transformers["s_nom"] = config.get("s_nom", 2000) | ||
if "s_nom" not in transformers: | ||
transformers["s_nom"] = config.get("s_nom", 2000) | ||
Comment on lines
+459
to
+460
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if some transformers have |
||
transformers["type"] = config.get("type", "") | ||
|
||
return transformers | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,7 +123,9 @@ def calc_gdp_pop(country, regions, gdp_non_nuts3, pop_non_nuts3): | |
if "snakemake" not in globals(): | ||
from _helpers import mock_snakemake | ||
|
||
snakemake = mock_snakemake("build_gdp_pop_non_nuts3") | ||
snakemake = mock_snakemake( | ||
"build_gdp_pop_non_nuts3", configfiles=["config/config.osm-raw.yaml"] | ||
) | ||
Comment on lines
+126
to
+128
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert? |
||
configure_logging(snakemake) | ||
set_scenario_config(snakemake) | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a short note why 200 kV disappears for clarification would be good.