make chp fuel flexible #1392

p-glaum · 2024-10-24T11:14:00Z

Changes proposed in this Pull Request

Allows you to define multiple fuels in config for which chps are added

Checklist

I tested my contribution locally and it works as intended.
Code and workflow changes are sufficiently documented.
Changed dependencies are added to envs/environment.yaml.
Changes in configuration options are added in config/config.default.yaml.
Changes in configuration options are documented in doc/configtables/*.csv.
Sources of newly added data are documented in doc/data_sources.rst.
A release note doc/release_notes.rst is added.

fneum

Proposed change makes sense. Some code style, documentation to be improved and a bug to be addressed before merging.

fneum · 2024-11-04T10:35:10Z

scripts/prepare_sector_network.py

-                efficiency3=costs.at["gas", "CO2 intensity"],
-                lifetime=costs.at["central gas CHP", "lifetime"],
-            )
+            fuel_type = options["chp"]["fuel_type"]


needs to be added to config.default.yaml and documented.

should have added this PR as draft. Just wanted to put it there that it is still on my to do.
But now I already addressed your comments.

fneum · 2024-11-04T10:35:57Z

scripts/prepare_sector_network.py

+            if not isinstance(fuel_type, list):
+                fuel_type = [fuel_type]


Suggested change

if not isinstance(fuel_type, list):

fuel_type = [fuel_type]

fuel_type = np.atleast_1d(fuel_type)

this is a nice shorthand for such things

fneum · 2024-11-04T10:39:04Z

scripts/prepare_sector_network.py

+            if not isinstance(fuel_type, list):
+                fuel_type = [fuel_type]
+            for fuel in fuel_type:
+                fuel_nodes = eval(f"spatial.{fuel}.df")


The eval() is a bit extravagant. Let's use something like getattr(spatial, fuel).df.

fneum · 2024-11-04T10:40:25Z

scripts/prepare_sector_network.py

+                    bus3="co2 atmosphere",
+                    carrier="urban central CHP",
+                    p_nom_extendable=True,
+                    capital_cost=costs.at["central gas CHP", "fixed"]


The release note and documentation of the config setting for the fuel types should state that the same costs as for gas CHP are used for all fuels! This might be a strong assumption, which is fine for now but we might want to revisit this later.

fneum · 2024-11-04T10:41:18Z

scripts/prepare_sector_network.py

-            )
+                n.madd(
+                    "Link",
+                    nodes + " urban central gas CHP CC",


Suggested change

nodes + " urban central gas CHP CC",

nodes + f" urban central {fuel} CHP CC",

Bug! Gas CHP CC is added multiple times.

prepare_sector_network: adress Fabians comments docs: add new config settings to doc

p-glaum · 2024-11-04T12:21:23Z

one thing we should still add is to check if all urban central heat buses exist. similar to #1407

Edit: not needed here, because nodes in CHPs only contain buses which have urban central heat

github-actions · 2024-11-04T12:58:49Z

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

master passed! ✅
feature/make_chp_flexible failed in: prepare_sector_network, prepare_sector_network, prepare_sector_network

Model Metrics

Benchmarks

Comparing feature/make_chp_flexible (6e9eeda) with master (acf089f).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2024-11-04 16:31:59 CET.

make chp flexible

ab9f591

p-glaum changed the title ~~make chp flexible~~ make chp fuel flexible Nov 1, 2024

fneum requested changes Nov 4, 2024

View reviewed changes

p-glaum added 3 commits November 4, 2024 13:05

default config: add settings

709121d

prepare_sector_network: adress Fabians comments docs: add new config settings to doc

Merge branch 'master' into feature/make_chp_flexible

8d67066

add release note

ea1521b

fix getattr bug

6e9eeda

fneum approved these changes Nov 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make chp fuel flexible #1392

make chp fuel flexible #1392

p-glaum commented Oct 24, 2024 •

edited

Loading

fneum left a comment

fneum Nov 4, 2024

p-glaum Nov 4, 2024

fneum Nov 4, 2024

p-glaum Nov 4, 2024

fneum Nov 4, 2024

p-glaum Nov 4, 2024

fneum Nov 4, 2024

p-glaum Nov 4, 2024

fneum Nov 4, 2024

p-glaum Nov 4, 2024

p-glaum commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading

	if not isinstance(fuel_type, list):
	fuel_type = [fuel_type]
	fuel_type = np.atleast_1d(fuel_type)

	nodes + " urban central gas CHP CC",
	nodes + f" urban central {fuel} CHP CC",

make chp fuel flexible #1392

Are you sure you want to change the base?

make chp fuel flexible #1392

Conversation

p-glaum commented Oct 24, 2024 • edited Loading

Changes proposed in this Pull Request

Checklist

fneum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

p-glaum commented Nov 4, 2024 • edited Loading

github-actions bot commented Nov 4, 2024 • edited Loading

Validator Report

p-glaum commented Oct 24, 2024 •

edited

Loading

p-glaum commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited

Loading