Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some refactoring and code cleaning #190

Merged
merged 21 commits into from
Dec 3, 2020
Merged

some refactoring and code cleaning #190

merged 21 commits into from
Dec 3, 2020

Conversation

fneum
Copy link
Member

@fneum fneum commented Sep 11, 2020

Changes proposed in this Pull Request

Admittedly multiple changes in one, but hopefully uncontroversial for the most part.

Reviewer, tick off boxes you agree on.

  • remove unused {network} wildcard
  • [ ] add pre-commit hooks
  • move conda environment files to envs folder
  • remove cluster.yaml and groups in Snakefile. Clean up for now, can be redone if needed.
  • remove sector-coupling components (CHP, heat pump etc) from config.yaml
  • some refactoring (sort imports, trailing whitespaces, move functions above __main__ if possible
  • remove broken code that has been commented out for ages

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • [ ] Newly introduced dependencies are added to environment.yaml and environment.docs.yaml.
  • [ ] Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • [ ] Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@fneum fneum added this to the Release v0.2.1 milestone Sep 26, 2020
@fneum fneum marked this pull request as ready for review November 26, 2020 16:29
@fneum
Copy link
Member Author

fneum commented Nov 26, 2020

Note: Merge #204 into this branch before merging all into master.

@FabianHofmann
Copy link
Contributor

Another point could be the removal of the plot scripts, make_summary and build_country_flh

@fneum fneum merged commit 2fc1ea0 into master Dec 3, 2020
@fneum fneum deleted the small-makeover branch December 3, 2020 18:50
fneum added a commit that referenced this pull request Mar 6, 2023
Add missing code directive and hyphon in tar operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants