Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit for formatting, liniting and code checking. #302

Closed
wants to merge 20 commits into from
Closed

Add pre-commit for formatting, liniting and code checking. #302

wants to merge 20 commits into from

Commits on Jan 11, 2022

  1. Create .yamllint

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    db03448 View commit details
    Browse the repository at this point in the history

  2. Create .pre-commit-config.yaml

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    50eed2b View commit details
    Browse the repository at this point in the history

  3. Update .pre-commit-config.yaml 

    Remove strictness for yamllint to prevent "Failed" precommit status on too long lines.

Remove width restriction on yamlfmt to prevent breaking of long lists which are then indented "inconsistently" according to yamllint.

(Arbitrary changes which seem reasonable at the moment; mainly caused by inconsistencies between pyaaml and ruamel.yaml).
    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a079006 View commit details
    Browse the repository at this point in the history

  4. Update .yamllint 

    Line length according to black (80 characters + <=10%).
    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    60886ba View commit details
    Browse the repository at this point in the history

  5. Remove symlinks checker (not needed) and don't tough LICENSES.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    28b898f View commit details
    Browse the repository at this point in the history

  6. Move comments from mapping to top (prevent removal by pyamlfmt).

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7202c3f View commit details
    Browse the repository at this point in the history

  7. Manually format .pre-commit-config.yaml for yamllint.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9c51c8e View commit details
    Browse the repository at this point in the history

  8. Add yamllint ignore lines for some options. 

    Option "braces = disable" removes validity of "{}" of entries in yaml file, but those are necessary for the configuration-> manual ignore required.
    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5f982f1 View commit details
    Browse the repository at this point in the history

  9. Revert to defaults for mapping indentation.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    591231d View commit details
    Browse the repository at this point in the history

  10. Try different yaml formatter.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1c98a80 View commit details
    Browse the repository at this point in the history

  11. Move from yamlfmt to pretty-format-yaml for yaml formatting.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d538939 View commit details
    Browse the repository at this point in the history

  12. Add automatic formatting of Snakefiles.

    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e539b36 View commit details
    Browse the repository at this point in the history

  13. Apply all formatters from pre-commit. 

    (Run `pre-commit run --all-files` )
    @euronion
    euronion committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a71a46b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Fix CI failing due to misaligned indentation from YAML formatting env… 

    …ironment.yaml.

glpk and ipopt should be installed via conda, due to indentation mismatch they were installed via pip (which failed).
    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    aa9e253 View commit details
    Browse the repository at this point in the history

  2. Add iosort and codespell for pre-commit.

    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    04e022c View commit details
    Browse the repository at this point in the history

  3. Have codespell ignore country codes and all CAPS words.

    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    4aa7578 View commit details
    Browse the repository at this point in the history

  4. Fix typos detected by codespell.

    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    73caf53 View commit details
    Browse the repository at this point in the history

  5. Run isort on all Python files.

    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    e2245c7 View commit details
    Browse the repository at this point in the history

  6. Add pre-commit hook for fixing midex-line-ending .

    @euronion
    euronion committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0fcb44d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Add check for large files (>2MB).

    @euronion
    euronion committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8b2ceda View commit details
    Browse the repository at this point in the history