-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider shipping routes for offshore potential calculation #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Code and example graphic.
Some smaller comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, I included the necessary dataset on zenodo and all ran smoothly locally. This can go in. Many thanks @p-glaum |
Partly tackles #34
Changes proposed in this Pull Request
In this pull request, we use the global shipping density dataset (https://datacatalog.worldbank.org/search/dataset/0037580/Global-Shipping-Traffic-Density) to exclude offshore areas in the offshore wind potential calculation.
ToDos
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.