Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shipping routes for offshore potential calculation #401

Merged
merged 12 commits into from
Aug 2, 2022

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented Jul 29, 2022

Partly tackles #34

Changes proposed in this Pull Request

In this pull request, we use the global shipping density dataset (https://datacatalog.worldbank.org/search/dataset/0037580/Global-Shipping-Traffic-Density) to exclude offshore areas in the offshore wind potential calculation.

ToDos

  • Add global shipping density dataset file to data bundles
  • Add a direct path to the already processed shipping density raster

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@p-glaum
Copy link
Contributor Author

p-glaum commented Jul 29, 2022

Here is an example, how the shipping routes exclusion (no further exclusions) would look like:
image

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Code and example graphic.

Some smaller comments:

Snakefile Outdated Show resolved Hide resolved
Snakefile Outdated Show resolved Hide resolved
config_float.yaml Outdated Show resolved Hide resolved
scripts/build_renewable_profiles.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
scripts/build_ship_raster.py Outdated Show resolved Hide resolved
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Last steps:

@fneum fneum enabled auto-merge August 2, 2022 13:58
@fneum
Copy link
Member

fneum commented Aug 2, 2022

Fantastic, I included the necessary dataset on zenodo and all ran smoothly locally. This can go in. Many thanks @p-glaum

@fneum fneum disabled auto-merge August 2, 2022 14:05
@fneum fneum merged commit a6052b6 into PyPSA:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants