Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line voltages alterantive #412

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix line voltages alterantive #412

merged 1 commit into from
Sep 5, 2022

Conversation

FabianHofmann
Copy link
Contributor

Closes #314
closes #410

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@FabianHofmann
Copy link
Contributor Author

@davide-f, this is a bit less code and should do what we want. You agree?

martacki
martacki approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@martacki martacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended! Thank you, @FabianHofmann

@davide-f
Copy link
Contributor

davide-f commented Sep 5, 2022

@davide-f, this is a bit less code and should do what we want. You agree?

Yeah the code is more elegant than #410 :)

@martacki martacki merged commit ef2633a into master Sep 5, 2022
@martacki martacki deleted the fix-simplify-alternative branch September 5, 2022 11:38
@pz-max pz-max mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martacki martacki martacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line capacity calculation in simplify_network.py
3 participants
@FabianHofmann @davide-f @martacki