Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit CI #416

Merged
merged 11 commits into from
Sep 19, 2022
Merged

Add pre-commit CI #416

merged 11 commits into from
Sep 19, 2022

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Sep 16, 2022 •
edited
Loading

Closes #302

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@fneum
Copy link
Member

fneum commented Sep 16, 2022

Oh, god, look at all those typos!

@FabianHofmann
Copy link
Contributor Author

Oh, god, look at all those typos!

:D

@fneum
Copy link
Member

fneum commented Sep 16, 2022

Lifting ipopt version constraint in CI helps CI to complete, see #417

@fneum
Copy link
Member

fneum commented Sep 16, 2022

You might also need to check (if the indentation of environment.yaml changed) how glpk and ipopt are added in the Github Action.

@FabianHofmann FabianHofmann merged commit 378d1ef into master Sep 19, 2022
@FabianHofmann FabianHofmann deleted the misc/precommit-ci-2 branch September 19, 2022 10:37
@FabianHofmann FabianHofmann mentioned this pull request Sep 19, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fneum fneum fneum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianHofmann @fneum