Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace progressbar by tqdm #478

Merged
merged 7 commits into from
Feb 22, 2023
Merged

replace progressbar by tqdm #478

merged 7 commits into from
Feb 22, 2023

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Feb 22, 2023

Initially the aim was to not let the output of the CI be bloat (which is the case with new prints of progressbars every half a second). However for that, I think we have to add an option to disable progressbars in general.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@FabianHofmann FabianHofmann marked this pull request as ready for review February 22, 2023 14:02
@fneum fneum merged commit e28e106 into master Feb 22, 2023
@fneum fneum deleted the tqdm-display branch February 22, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants